Fix C# references, symbol ranges, and inspect file-line mode - #4032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path.Combine,Math.Max, andJsonElement.GetStringwhile preserving direct andthis.calls.inspect --path --lineresolve the exact symbol on definition lines or the smallest enclosing symbol on body lines, returningdefinitionsandnearby_symbolsinstead of only a source excerpt.origin/mainand updated the legacy Show source excerpts and line ranges from cdidx inspect #3786 path-line inspect test expectation that was failing CI after the Make inspect file-line mode return the exact or enclosing symbol #3915 behavior change.Validation
dotnet build -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~Issue3786 -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~Issue3894 -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~Issue3912 -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~Issue3915 -p:UseSharedCompilation=falsedotnet run --project tools/CodeIndex.Changelog -- checkdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsondotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll inspect --path src/CodeIndex/Cli/QueryCommandRunner.cs --line 3120 --json --limit 3Changelog
changelog.d/unreleased/3894.fixed.mdchangelog.d/unreleased/3912.fixed.mdchangelog.d/unreleased/3915.fixed.mdNotes
AGENT.md,CLAUDE.md, andAGENT_GUIDE.mdwere not modified by this PR diff against latestorigin/main.Fixes #3894
Fixes #3912
Fixes #3915